Don't throw error if user cancels out of choosing a language#2365
Merged
shati-patel merged 1 commit intomainfrom Apr 21, 2023
Merged
Don't throw error if user cancels out of choosing a language#2365shati-patel merged 1 commit intomainfrom
shati-patel merged 1 commit intomainfrom
Conversation
When running "Create Query", if the user escapes out of the language quickpick we don't need to throw an error. Instead we can just show a `UserCancellationException` notice.
robertbrignull
approved these changes
Apr 20, 2023
Contributor
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
LGTM
I've tried it out and the experience is a lot nicer when you cancel the wizard. Thanks for spotting that and addressing it!
| }); | ||
|
|
||
| return await askForLanguage(this.cliServer, false); | ||
| return await askForLanguage(this.cliServer, true); |
Contributor
There was a problem hiding this comment.
That throwOnEmpty argument is confusingly named, but that's not the fault of this PR 😅
Contributor
Author
There was a problem hiding this comment.
I agree! To me, it's something more like "always throw, but less aggressively" 🙃
I'll leave it as-is for now though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small tweak: When running "Create Query", if the user escapes out of the language quickpick we don't need to throw an error. Instead we can just show a
UserCancellationExceptionnotice.Checklist
N/A—this is still behind a feature-flag.
ready-for-doc-reviewlabel there.